-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upload to AZ as well as S3 #33573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming release builds run properly.
Gonna merge to test in the nightly, if it fails we can revert |
No Release Notes |
I was unable to backport this PR to "15-x-y" cleanly; |
I was unable to backport this PR to "16-x-y" cleanly; |
I was unable to backport this PR to "17-x-y" cleanly; |
I was unable to backport this PR to "18-x-y" cleanly; |
@MarshallOfSound has manually backported this PR to "18-x-y", please check out #33924 |
@MarshallOfSound has manually backported this PR to "17-x-y", please check out #33925 |
@MarshallOfSound has manually backported this PR to "16-x-y", please check out #33926 |
@MarshallOfSound has manually backported this PR to "15-x-y", please check out #33927 |
* build: upload to AZ aswell as S3 * fix: provide env to azput
* build: upload to AZ aswell as S3 * fix: provide env to azput
This duplicates our upload logic so that all files are uploaded to both S3 and our new AZ storage containers. This patch also switches our checksum generation logic to use the AZ storage container exclusively.
Notes: no-notes